cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] DaanHoogland opened a new pull request #2517: Msad ldap fixes
Date Fri, 30 Mar 2018 09:11:40 GMT
DaanHoogland opened a new pull request #2517: Msad ldap fixes
URL: https://github.com/apache/cloudstack/pull/2517
 
 
   ## Description
   ldap accounts that where not automatically imported but mapped manually were not able to
login. fixed.
   
   see https://lists.apache.org/thread.html/43ef6cc4bcf12340f8ac1c05fbcb7bf3afc3d6ed3b05ff509b9c6152@%3Cusers.cloudstack.apache.org%3E
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that
apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   this has only unit tests as an integration test requires an external system
   
   it was tested manually using an openldap and a microsoft ad implementation
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
   - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   - [x] I have added tests to cover my changes.
   - [x] All new and existing tests passed.
   
   <!-- The following will kick a packaging job, remove if as applicable -->
   @blueorangutan package
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message