cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mike-tutkowski commented on a change in pull request #2503: Support multiple volume access groups per compute cluster
Date Thu, 29 Mar 2018 18:45:07 GMT
mike-tutkowski commented on a change in pull request #2503: Support multiple volume access
groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r178148281
 
 

 ##########
 File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
 ##########
 @@ -2778,9 +2838,25 @@ private void unmountVmfsDatastore(VmwareContext context, VmwareHypervisorHost
hy
         for (Pair<ManagedObjectReference, String> host : hosts) {
             HostMO hostMO = new HostMO(context, host.first());
 
-            HostStorageSystemMO hostStorageSystemMO = hostMO.getHostStorageSystemMO();
+            if (isDatastoreMounted(dsMO, hostMO)) {
+                HostStorageSystemMO hostStorageSystemMO = hostMO.getHostStorageSystemMO();
+
+                hostStorageSystemMO.unmountVmfsVolume(getDatastoreUuid(dsMO, hostMO));
+            }
+        }
+    }
+
+    private void unmountVmfsDatastore2(VmwareContext context, VmwareHypervisorHost hyperHost,
String datastoreName,
 
 Review comment:
   Same story for verifyAllHostsMountedDatastore and verifyAllHostsMountedDatastore2. I plan
to make verifyAllHostsMountedDatastore leverage verifyAllHostsMountedDatastore2.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message