cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on a change in pull request #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM
Date Thu, 29 Mar 2018 11:58:37 GMT
rhtyd commented on a change in pull request #2505: CLOUDSTACK-10333: Secure Live VM Migration
for KVM
URL: https://github.com/apache/cloudstack/pull/2505#discussion_r178033101
 
 

 ##########
 File path: agent/src/com/cloud/agent/Agent.java
 ##########
 @@ -274,6 +279,19 @@ public void start() {
             }
         }
         _shell.updateConnectedHost();
+
+        // In case of software based restart, GC to remove old instances
+        _executor.submit(new Runnable() {
 
 Review comment:
   Yes @rafaelweingartner, with the feature we've introduced a background thread that will
perform software based restart of the agent. Look at the post renewal restart task. With this
it will be easier to restart an agent without actually restarting the agent JVM process. This
runnable is needed to GC old agent instance, we can remove this as well, but keeping it ensures
that old agent is stopped+GC-ed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message