From commits-return-72400-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Fri Feb 23 20:52:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 85267180652 for ; Fri, 23 Feb 2018 20:52:09 +0100 (CET) Received: (qmail 46133 invoked by uid 500); 23 Feb 2018 19:52:08 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 46124 invoked by uid 99); 23 Feb 2018 19:52:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Feb 2018 19:52:08 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] syed commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering Message-ID: <151941552803.24221.15665662175162164367.gitbox@gitbox.apache.org> syed commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170351240 ########## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ########## @@ -2566,6 +2567,61 @@ protected DiskOfferingVO createDiskOffering(final Long userId, final Long domain isCustomized = true; } + if (minIopsPerGb != null || maxIopsPerGb != null) { + + if (!isCustomized) { + throw new InvalidParameterValueException("Cannot set Min/Max IOPS/GB for a fixed size disk offering"); Review comment: You cannot have an IOPS/GB offering for a fixed sized disk. The whole Idea of an IOPS/GB type of offering makes sense when you have a custom offering so when you change the size of a disk, the IOPS also change ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services