From commits-return-72295-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Thu Feb 22 16:27:17 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7308A18064E for ; Thu, 22 Feb 2018 16:27:17 +0100 (CET) Received: (qmail 2911 invoked by uid 500); 22 Feb 2018 15:27:16 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 2898 invoked by uid 99); 22 Feb 2018 15:27:16 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Feb 2018 15:27:16 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco? Message-ID: <151931323593.20103.3539397003965784161.gitbox@gitbox.apache.org> rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco? URL: https://github.com/apache/cloudstack/pull/2455#discussion_r169993368 ########## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ########## @@ -2526,7 +2526,7 @@ private void orchestrateMigrateWithStorage(final String vmUuid, final long srcHo final String zoneName = _dcDao.findById(vm.getDataCenterId()).getName(); boolean isWindows = _guestOSCategoryDao.findById(_guestOSDao.findById(vm.getGuestOSId()).getCategoryId()).getName().equalsIgnoreCase("Windows"); - vmData = _networkModel.generateVmData(userVm.getUserData(), serviceOffering, zoneName, vm.getInstanceName(), vm.getId(), + vmData = _networkModel.generateVmData(userVm.getUserData(), serviceOffering, zoneName, vm.getInstanceName(), vm.getHostName(), vm.getId(), Review comment: Of course there is. I am not talking about the object you create we the call `generateVmData`. I am talking about the object from which you are retrieving data `vm`. That object is an instance of `UserVmVO`, which extends `VMInstanceVO`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services