From commits-return-71642-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Mon Feb 5 17:06:01 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id D22A3180647 for ; Mon, 5 Feb 2018 17:06:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C12D9160C4B; Mon, 5 Feb 2018 16:06:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3D242160C46 for ; Mon, 5 Feb 2018 17:06:01 +0100 (CET) Received: (qmail 73941 invoked by uid 500); 5 Feb 2018 16:06:00 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 73932 invoked by uid 99); 5 Feb 2018 16:06:00 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Feb 2018 16:06:00 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] sgoeminn commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update to a nuage network of? Message-ID: <151784675982.4174.6737166423361687899.gitbox@gitbox.apache.org> sgoeminn commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update to a nuage network of? URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166019251 ########## File path: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java ########## @@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network, VirtualMachineProfile vm, D HostVO nuageVspHost = _nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId()); VspNetwork vspNetwork = _nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), network); - if (vm.getType() == VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp().equals("null")) { + boolean isUpgradeNetworkOffering = vm.getType() == VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp() Review comment: @DaanHoogland if a VR is spinned in a network that currently has no virtual router ip (vspNetwork.getVRip==null), it means that there was no virtual router before and that the network offering is changed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services