cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] syed commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering
Date Thu, 01 Jan 1970 00:00:00 GMT
syed commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170351240
 
 

 ##########
 File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##########
 @@ -2566,6 +2567,61 @@ protected DiskOfferingVO createDiskOffering(final Long userId, final
Long domain
             isCustomized = true;
         }
 
+        if (minIopsPerGb != null || maxIopsPerGb != null) {
+
+            if (!isCustomized) {
+               throw new InvalidParameterValueException("Cannot set Min/Max IOPS/GB for a
fixed size disk offering");
 
 Review comment:
   You cannot have an IOPS/GB offering for a fixed sized disk. The whole Idea of an IOPS/GB
type of offering makes sense when you have a custom offering so when you change the size of
a disk, the IOPS also change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message