cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mrunalinikankariya commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?
Date Thu, 01 Jan 1970 00:00:00 GMT
mrunalinikankariya commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in
metadata when using external DNS is inco?
URL: https://github.com/apache/cloudstack/pull/2455#discussion_r169992289
 
 

 ##########
 File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
 ##########
 @@ -2526,7 +2526,7 @@ private void orchestrateMigrateWithStorage(final String vmUuid, final
long srcHo
                     final String zoneName = _dcDao.findById(vm.getDataCenterId()).getName();
                     boolean isWindows = _guestOSCategoryDao.findById(_guestOSDao.findById(vm.getGuestOSId()).getCategoryId()).getName().equalsIgnoreCase("Windows");
 
-                    vmData = _networkModel.generateVmData(userVm.getUserData(), serviceOffering,
zoneName, vm.getInstanceName(), vm.getId(),
+                    vmData = _networkModel.generateVmData(userVm.getUserData(), serviceOffering,
zoneName, vm.getInstanceName(), vm.getHostName(), vm.getId(),
 
 Review comment:
   There is no displayname parameter in VirtualMachine.java. Also hostName refers to name
parameter only

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message