cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?
Date Thu, 01 Jan 1970 00:00:00 GMT
rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in
metadata when using external DNS is inco?
URL: https://github.com/apache/cloudstack/pull/2455#discussion_r169939634
 
 

 ##########
 File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
 ##########
 @@ -2526,7 +2526,7 @@ private void orchestrateMigrateWithStorage(final String vmUuid, final
long srcHo
                     final String zoneName = _dcDao.findById(vm.getDataCenterId()).getName();
                     boolean isWindows = _guestOSCategoryDao.findById(_guestOSDao.findById(vm.getGuestOSId()).getCategoryId()).getName().equalsIgnoreCase("Windows");
 
-                    vmData = _networkModel.generateVmData(userVm.getUserData(), serviceOffering,
zoneName, vm.getInstanceName(), vm.getId(),
+                    vmData = _networkModel.generateVmData(userVm.getUserData(), serviceOffering,
zoneName, vm.getInstanceName(), vm.getHostName(), vm.getId(),
 
 Review comment:
   @mrunalinikankariya you want to send the name set by the user for the given VM, right?
They are the parameters "displayname" and "name" that the user can enter when deploying a
VM. 
   
   Even though this "hostName" contains that parameter "name", I get the feeling that it is
not the right one to use. It looks like an inconsistent sent of value that can and should
be fixed in the future. If you look into the VM's POJO, we have hostId and hostName; for sanity,
I would consider them the same thing. Therefore, hostId is the id of the host where the VM
is running, and the hostName is the name of the host where the VM is running.
   
   Therefore, I believe you should use "displayName" or "name" attributes instead of the "hostName".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message