From commits-return-71433-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Sat Jan 27 10:51:26 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E3B0118065B for ; Sat, 27 Jan 2018 10:51:26 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D2E9B160C30; Sat, 27 Jan 2018 09:51:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1F08D160C2F for ; Sat, 27 Jan 2018 10:51:25 +0100 (CET) Received: (qmail 20188 invoked by uid 500); 27 Jan 2018 09:51:25 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 20179 invoked by uid 99); 27 Jan 2018 09:51:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Jan 2018 09:51:25 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] DaanHoogland commented on a change in pull request #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons Message-ID: <151704668462.18333.15287120647273590825.gitbox@gitbox.apache.org> DaanHoogland commented on a change in pull request #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons URL: https://github.com/apache/cloudstack/pull/2431#discussion_r164268400 ########## File path: utils/src/main/java/com/cloud/utils/StringUtils.java ########## @@ -78,12 +76,13 @@ public static String join(final String delimiter, final Object... components) { return org.apache.commons.lang.StringUtils.join(components, delimiter); } + /** + * @deprecated + * Please use org.apache.commons.lang.StringUtils.IsBlank() as a replacement Review comment: missed that one :( ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services