From commits-return-70677-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Wed Jan 10 22:21:44 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7E96B18072F for ; Wed, 10 Jan 2018 22:21:44 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6E872160C2E; Wed, 10 Jan 2018 21:21:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D9008160C1E for ; Wed, 10 Jan 2018 22:21:43 +0100 (CET) Received: (qmail 98841 invoked by uid 500); 10 Jan 2018 21:21:43 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 98830 invoked by uid 99); 10 Jan 2018 21:21:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 21:21:43 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage Message-ID: <151561930243.11174.13993252217080989503.gitbox@gitbox.apache.org> mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-356740607 @rafaelweingartner Sure, I'm happy to help. A couple things: 1) If you are just looking for a host to perform the operation (in my use case, it's a copy of a volume snapshot that's on secondary storage to a new template, which is also, as always, on secondary storage), then you don't need that join on the cluster_details table in HostDaoImpl.createSqlFindHostConnectedToStoragePoolToExecuteCommand. We only need to check that field in cluster_details when we'd like to perform a UUID resignature of an SR and/or a VDI on XenServer, which we don't here. 2) I'm curious why we don't just do the following: Look up the hypervisor type of the volume snapshot in cloud.snapshots. Find any host of that hypervisor type in the applicable zone and use it to perform the operation. This would solve the problem of having to find a storage pool that may no longer be in use. In any event, once the volume snapshot is on secondary storage, we don't really care what storage pool it came from, right? I think we just care what hypervisor type it came from. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services