From commits-return-70531-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Tue Jan 9 11:11:12 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 1C7D4180718 for ; Tue, 9 Jan 2018 11:11:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0CA41160C2D; Tue, 9 Jan 2018 10:11:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 49778160C13 for ; Tue, 9 Jan 2018 11:11:11 +0100 (CET) Received: (qmail 3867 invoked by uid 500); 9 Jan 2018 10:11:10 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 3858 invoked by uid 99); 9 Jan 2018 10:11:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jan 2018 10:11:10 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] rhtyd commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support Message-ID: <151549266989.14924.3281275688764579919.gitbox@gitbox.apache.org> rhtyd commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160364847 ########## File path: tools/marvin/marvin/config/test_data.py ########## @@ -49,6 +49,27 @@ "forvirtualnetwork": "true", "vlan": "300" }, + "publiciprange1": { + "gateway": "10.200.100.1", + "netmask": "255.255.255.0", + "startip": "10.200.100.101", + "endip": "10.200.100.105", + "forvirtualnetwork": "false" + }, + "publiciprange2": { + "gateway": "10.219.1.1", + "netmask": "255.255.255.0", + "startip": "10.219.1.2", + "endip": "10.219.1.5", + "forvirtualnetwork": "false" + }, + "publiciprange3": { + "gateway": "10.200.100.1", + "netmask": "255.255.255.0", + "startip": "10.200.100.2", + "endip": "10.200.100.20", + "forvirtualnetwork": "false" + }, Review comment: @fmaximus can you move the test data to test itself? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services