cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string
Date Thu, 01 Jan 1970 00:00:00 GMT
rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean
instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360220812
 
 
   @marcaurele can you run test_hostha_simulator.py smoketest against simulator in your local
environment and see if you can reproduce and fix the failure? You can look at Travis log (scroll
to the bottom, or see the raw logs), you'll find error such as following:
   ```
   Traceback (most recent call last):
     File "/home/travis/build/apache/cloudstack/test/integration/smoke/test_hostha_simulator.py",
line 531, in test_ha_verify_fsm_available
       self.configureSimulatorHAProviderState(True, True, True, False)
     File "/home/travis/build/apache/cloudstack/test/integration/smoke/test_hostha_simulator.py",
line 164, in configureSimulatorHAProviderState
       self.assertEqual(response.success, 'true')
   AssertionError: True != 'true'
   ```
   
   I think we'll need to discuss this on dev@, as this change may potentially cause regression
for API consumers?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message