cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] DaanHoogland commented on a change in pull request #2430: CLOUDSTACK-10239 default provider if needed
Date Thu, 01 Jan 1970 00:00:00 GMT
DaanHoogland commented on a change in pull request #2430: CLOUDSTACK-10239 default provider
if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163628911
 
 

 ##########
 File path: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ##########
 @@ -54,11 +54,11 @@
     @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, required = true, description
= "type of the ldap name. GROUP or OU")
     private String type;
 
-    @Parameter(name = ApiConstants.LDAP_DOMAIN, type = CommandType.STRING, required = true,
description = "name of the group or OU in LDAP")
+    @Parameter(name = ApiConstants.LDAP_DOMAIN, type = CommandType.STRING, required = false,
description = "name of the group or OU in LDAP")
 
 Review comment:
   the validation of the field is done deeper in the stack. A check is done to see if either
ldapdomain or name is filled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message