cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after #2283
Date Thu, 01 Jan 1970 00:00:00 GMT
rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after
#2283
URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162896571
 
 

 ##########
 File path: plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/objects/OvmObject.java
 ##########
 @@ -172,7 +172,7 @@ public Boolean getSuccess() {
                     if (nodeListFor2.getLength() > 1) {
                         /* Do we need to figure out all the sub elements here and put them
in a map? */
                     } else {
-                        String element = nodeListFor.item(index).getTextContent();
+                        String element = nodeListFor.item(index).getNodeValue();
 
 Review comment:
   Yes, there were more changes than the renaming. These other files were not compiling at
all. The method `getTextContent` does not exist anymore in XML-APIs. So, this looks like a
problem that was ignored during dependencies upgrade. Just to make things clear... I am not
upgrading these dependencies with this PR, this was already there when I started fixing the
classes that were moved to wrong directories.
   
   The same happens in the code where I had to update the use of `VolumeVO` and `SnapshotVO`.
Someone seems to have changed the signature of the method, but did not fix it everywhere.
   
   A similar problem is found for `DirectAgentManagerSimpleImpl.java`, it was not implementing
all of the methods from one of its interfaces.
   
   And in `VmSnapshotDaoTest.java`, there is something that would never compile. Someone changed
the `VMSnapshotDetailsVO` signature, but did not change all of the places that use it. Therefore,
there was an instantiation where the third variable was receiving something called `display`.
This `display` is not a variable in that context. It is something auto-generated by Eclipse.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message