cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] DaanHoogland commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support
Date Thu, 01 Jan 1970 00:00:00 GMT
DaanHoogland commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: Extending
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160032281
 
 

 ##########
 File path: api/src/com/cloud/network/NetworkModel.java
 ##########
 @@ -79,12 +103,34 @@
 
     List<? extends Network> listNetworksUsedByVm(long vmId, boolean isSystem);
 
+    /**
 
 Review comment:
   I don't think these four javadoc additions add to the readability of the code. They say
nothing beyond what the naming of the method and parameters already tell us.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message