cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
Date Thu, 01 Jan 1970 00:00:00 GMT
rhtyd commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage
for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r160031077
 
 

 ##########
 File path: agent/src/com/cloud/agent/Agent.java
 ##########
 @@ -600,6 +608,47 @@ protected void processRequest(final Request request, final Link link)
{
         }
     }
 
+    private Answer setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd) {
+        String certificate = cmd.getCertificate();
+        String certificateName = cmd.getCertificateName();
+        s_logger.info("Importing certificate " + certificateName + " into keystore");
+
+        final File agentFile = PropertiesUtil.findConfigFile("agent.properties");
+        if (agentFile == null) {
+            return new Answer(cmd, false, "Failed to find agent.properties file");
+        }
+
+        final String keyStoreFile = agentFile.getParent() + "/" + KeyStoreUtils.defaultKeystoreFile;
 
 Review comment:
   I would prefer going the script way, perhaps re-using one of the import keystore/cert scripts.
Alternatively, `KeyStore` could be read and manipulated (keys imported etc) by using Java
only, agreeing with what @rafaelweingartner suggested.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message