cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] DaanHoogland commented on a change in pull request #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates
Date Thu, 01 Jan 1970 00:00:00 GMT
DaanHoogland commented on a change in pull request #2146: CLOUDSTACK-4757: Support OVA files
with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r160027409
 
 

 ##########
 File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
 ##########
 @@ -443,6 +449,37 @@ public String getKeyboard() {
         return dhcpOptionsMap;
     }
 
+    public Map<Long, DiskOffering> getDataDiskTemplateToDiskOfferingMap() {
+        if (diskOfferingId != null && dataDiskTemplateToDiskOfferingList != null)
{
 
 Review comment:
   @rafaelweingartner only the second part of the first if()s condition can be removed and
the semantics woud slightly change as an exception instead of an empty map is really different.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message