cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
Date Thu, 01 Jan 1970 00:00:00 GMT
mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355684146
 
 
   I've added the following comment to the canHandle method:
   
       // canHandle returns true if the storage driver for the DataObject that's passed in
can support certain features (what features we
       // care about during a particular invocation of this method depend on what type of
DataObject was passed in (ex. VolumeInfo versus SnapshotInfo).
   
   Perhaps the method name is misleading. It might be interpreted to mean we can't do anything
with this object if canHandle returns false. In reality, if canHandle returns true, we know
you support certain features and we handle you a particular way. If it returns false, we might
throw an exception or we might be able to handle you another way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message