cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] nvazquez commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
Date Thu, 01 Jan 1970 00:00:00 GMT
nvazquez commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage
for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878781
 
 

 ##########
 File path: agent/src/com/cloud/agent/Agent.java
 ##########
 @@ -600,6 +608,47 @@ protected void processRequest(final Request request, final Link link)
{
         }
     }
 
+    private Answer setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd) {
+        String certificate = cmd.getCertificate();
+        String certificateName = cmd.getCertificateName();
+        s_logger.info("Importing certificate " + certificateName + " into keystore");
+
+        final File agentFile = PropertiesUtil.findConfigFile("agent.properties");
+        if (agentFile == null) {
+            return new Answer(cmd, false, "Failed to find agent.properties file");
+        }
+
+        final String keyStoreFile = agentFile.getParent() + "/" + KeyStoreUtils.defaultKeystoreFile;
 
 Review comment:
   Yes, I prefer using this java approach for those that can be done instead of using a script
file. If you prefer I can refactor it to a script file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message