cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] DaanHoogland commented on a change in pull request #2380: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.
Date Thu, 01 Jan 1970 00:00:00 GMT
DaanHoogland commented on a change in pull request #2380: CLOUDSTACK-8855 Improve Error Message
for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2380#discussion_r159825666
 
 

 ##########
 File path: engine/components-api/src/com/cloud/agent/AgentManager.java
 ##########
 @@ -143,7 +143,7 @@
 
     public void pullAgentOutMaintenance(long hostId);
 
-    boolean reconnect(long hostId);
+    void reconnect(long hostId) throws AgentUnavailableException;
 
 Review comment:
   this change is breaking things. We need to look at it. @rafaelweingartner CAManagerImpl.java
needs the boolean. should we take this to 4.12? I'm not taking the time now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message