cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mike-tutkowski commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage
Date Thu, 01 Jan 1970 00:00:00 GMT
mike-tutkowski commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r159562974
 
 

 ##########
 File path: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
 ##########
 @@ -1426,19 +1998,66 @@ private Answer attachVolume(Command cmd, DiskTO disk, boolean isAttach,
boolean
         } catch (Throwable e) {
             if (e instanceof RemoteException) {
                 s_logger.warn("Encounter remote exception to vCenter, invalidate VMware session
context");
+
                 hostService.invalidateServiceContext(null);
             }
 
             String msg = "";
-            if (isAttach)
+
 
 Review comment:
   I tend to separate variables from the code that operates on them with line spacing. I don't
like reading people's code that is completely crammed together, so I don't write it that way.
I'm sure some like the extra spacing and others don't.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message