Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: GitBox <git@apache.org>
To: commits@cloudstack.apache.org
Subject: [GitHub] rhtyd commented on a change in pull request #2370: CLOUDSTACK-9595: Fix regression introduced in #1762
Message-ID: <151376473050.8257.4252718810490984750.gitbox@gitbox.apache.org>
archived-at: Wed, 20 Dec 2017 10:12:12 -0000

rhtyd commented on a change in pull request #2370: CLOUDSTACK-9595: Fix regression introduced in #1762
URL: https://github.com/apache/cloudstack/pull/2370#discussion_r157983244
 
 
 ##########
 File path: server/src/com/cloud/network/IpAddressManagerImpl.java
 ##########
 @@ -936,8 +942,8 @@ public PublicIp assignDedicateIpAddress(Account owner, final Long guestNtwkId, f
                 displayIp = vpc.isDisplay();
             }
 
-            return fetchNewPublicIp(dcId, null, null, owner, VlanType.VirtualNetwork, guestNtwkId, isSourceNat, false, null, false, vpcId, displayIp);
-
+            ip = fetchNewPublicIp(dcId, null, null, owner, VlanType.VirtualNetwork, guestNtwkId, isSourceNat, true, null, false, vpcId, displayIp);
 
 Review comment:
   @rafaelweingartner actually there is a `ip` variable that is used in `finally` which is why I assign and then return see the code below this line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services