Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6D8D4200D5F for ; Mon, 18 Dec 2017 19:43:34 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6C020160C05; Mon, 18 Dec 2017 18:43:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AABA7160BFB for ; Mon, 18 Dec 2017 19:43:33 +0100 (CET) Received: (qmail 1032 invoked by uid 500); 18 Dec 2017 18:43:32 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 1023 invoked by uid 99); 18 Dec 2017 18:43:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Dec 2017 18:43:32 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] rafaelweingartner commented on issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod Message-ID: <151362261215.24311.318708312942204828.gitbox@gitbox.apache.org> archived-at: Mon, 18 Dec 2017 18:43:34 -0000 rafaelweingartner commented on issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod URL: https://github.com/apache/cloudstack/pull/1278#issuecomment-352520517 @rhtyd I have a lot of doubts about this PR. It says > Virtual router gets deployed in disabled Pod However, I still do not see how the changes it is introducing will make sure that a VR does not get deployed in a disabled Pod. I do not see any check if a Pod is disabled or not when VRs are deployed. Do you see this in the code? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services