cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] krissterckx commented on a change in pull request #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
Date Thu, 01 Jan 1970 00:00:00 GMT
krissterckx commented on a change in pull request #2374: CLOUDSTACK-10024: Network Migration:
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#discussion_r158944104
 
 

 ##########
 File path: tools/marvin/marvin/config/test_data.py
 ##########
 @@ -419,8 +419,8 @@
         "displaytext": "MySharedOffering",
         "guestiptype": "Shared",
         "supportedservices": "Dhcp,Dns,UserData",
-        "specifyVlan": "True",
-        "specifyIpRanges": "True",
+        "specifyVlan": "False",
 
 Review comment:
   @rhtyd this change is exactly the revert you asked for. I think we shd merge in this PR
as your comment was legitimate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message