cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates
Date Thu, 01 Jan 1970 00:00:00 GMT
rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757: Support OVA
files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158581896
 
 

 ##########
 File path: engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java
 ##########
 @@ -288,6 +309,62 @@ public void resize(DataObject data, AsyncCompletionCallback<CreateCmdResult>
cal
     }
 
     @Override
-    public void deleteEntityExtractUrl(DataStore store, String installPath, String url, Upload.Type
entityType){
+    public void deleteEntityExtractUrl(DataStore store, String installPath, String url, Upload.Type
entityType) {
+    }
+
+    @Override
+    public List<DatadiskTO> getDataDiskTemplates(DataObject obj) {
+        List<DatadiskTO> dataDiskDetails = new ArrayList<DatadiskTO>();
+        if (s_logger.isDebugEnabled()) {
+            s_logger.debug("Get the data disks present in the OVA template");
+        }
+        DataStore store = obj.getDataStore();
+        GetDatadisksCommand cmd = new GetDatadisksCommand(obj.getTO());
+        //EndPoint ep = _defaultEpSelector.selectHypervisorHostByType(store.getScope(), HypervisorType.VMware);
 
 Review comment:
   commented code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message