cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] marcaurele commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9
Date Thu, 01 Jan 1970 00:00:00 GMT
marcaurele commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate
to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158201994
 
 

 ##########
 File path: python/lib/cloudutils/utilities.py
 ##########
 @@ -216,8 +216,8 @@ def isKVMEnabled(self):
 class serviceOpsRedhat7(serviceOps):
     def isServiceRunning(self, servicename):
         try:
-            o = bash("systemctl status " + servicename)
-            if "running" in o.getStdout() or "start" in o.getStdout() or "Running" in o.getStdout():
+            o = bash("systemctl is-active " + servicename)
+            if "inactive" not in o.getStdout():
 
 Review comment:
   if statement can be simplified to: `return "inactive" not in o.getStdout()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message