cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rafaelweingartner commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2)
Date Thu, 01 Jan 1970 00:00:00 GMT
rafaelweingartner commented on a change in pull request #2281: CLOUDSTACK-10102: New network
type (L2)
URL: https://github.com/apache/cloudstack/pull/2281#discussion_r157728263
 
 

 ##########
 File path: server/src/com/cloud/network/NetworkModelImpl.java
 ##########
 @@ -1823,6 +1826,9 @@ public boolean isNetworkAvailableInDomain(long networkId, long domainId)
{
 
     @Override
     public Set<Long> getAvailableIps(Network network, String requestedIp) {
+        if (network.getCidr() == null) {
+            return null;
 
 Review comment:
   Instead of `null`, what about an empty set here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message