cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rafaelweingartner commented on a change in pull request #2352: CLOUDSTACK-10175: prevent VPC list leakage
Date Thu, 01 Jan 1970 00:00:00 GMT
rafaelweingartner commented on a change in pull request #2352: CLOUDSTACK-10175: prevent VPC
list leakage
URL: https://github.com/apache/cloudstack/pull/2352#discussion_r155369392
 
 

 ##########
 File path: server/src/com/cloud/user/AccountManagerImpl.java
 ##########
 @@ -2472,6 +2464,11 @@ public void buildACLSearchParameters(Account caller, Long id, String
accountName
                 if (projectId.longValue() == -1) {
                     if (caller.getType() == Account.ACCOUNT_TYPE_NORMAL) {
                         permittedAccounts.addAll(_projectMgr.listPermittedProjectAccounts(caller.getId()));
+
+                        //permittedAccounts can be empty when the caller is not a part of
any project (a domain account)
+                        if (permittedAccounts.isEmpty()) {
 
 Review comment:
   thanks!
   So, it seems that the code was not formatted properly before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message