cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds
Date Thu, 01 Jan 1970 00:00:00 GMT
rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out
in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r153505547
 
 

 ##########
 File path: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ##########
 @@ -98,28 +98,31 @@
     @Override
     public boolean execute(VmwareHostService hostService, CreateEntityDownloadURLCommand
cmd) {
         DataTO data = cmd.getData();
+        int timeout = NumbersUtil.parseInt(cmd.getContextParam(VmwareManager.s_vmwareOVAPackageTimeout.key()),
VmwareManagerImpl.DEFAULT_VM_OVA_PACKAGE_TIMEOUT);
 
 Review comment:
   Instead of `DEFAULT_VM_OVA_PACKAGE_TIMEOUT` use the value dynamically by calling a method
or reading the current value, using the ConfigKey (i.e. multiply them). This will enable admins
to change value and enforce new settings without restarting the mgmt server(s).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message