cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on a change in pull request #2335: CLOUDSTACK-10154: fixing some smoketests failures
Date Thu, 01 Jan 1970 00:00:00 GMT
rhtyd commented on a change in pull request #2335: CLOUDSTACK-10154: fixing some smoketests
failures
URL: https://github.com/apache/cloudstack/pull/2335#discussion_r153122106
 
 

 ##########
 File path: test/integration/smoke/test_volumes.py
 ##########
 @@ -858,7 +858,7 @@ def test_10_list_volumes(self):
 
     def wait_for_attributes_and_return_root_vol(self):
 
-        for i in range(60):
+        for i in range(360):
 
 Review comment:
   @borisstoyanov can you rewrite the test using wait_until instead, for example:
   ```
   # If not import do this:
   from marvin.lib.utils import wait_until
   [...snipped...]
   
        def wait_for_attributes_and_return_root_vol(self):
           def checkVolumeResponse():
                  list_volume_response = Volume.list(
                     self.apiClient,
                     virtualmachineid=self.virtual_machine.id,
                    type='ROOT',
                    listall=True
                )
                if  list_volume_response[0].virtualsize is not None:
                    return True, list_volume_response[0]
                return False, None
   
           # sleep interval is 1s, retries is 360, this will sleep atmost 360 seconds, or
6 mins
           res, response = wait_until(1, 360, checkVolumeResponse)                       
                                              
           if not res:                                                                
               self.fail("Failed to return root volume response")                 
           return response 
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message