cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag
Date Thu, 01 Jan 1970 00:00:00 GMT
yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922:  Unable to delete
IP tag
URL: https://github.com/apache/cloudstack/pull/905#discussion_r152729068
 
 

 ##########
 File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java
 ##########
 @@ -360,6 +348,53 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
         return true;
     }
 
+    private List<? extends ResourceTag>  getResourceTags(final List<String> resourceIds,
ResourceObjectType resourceType) {
+
+        List<String> uuids = new ArrayList<String>();
+        List<String> internalIds = new ArrayList<String>();
 
 Review comment:
   No, putting internalIds does not help in anyway, as we get are using them again to construct
the query

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message