cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] bwsw commented on issue #2322: CLOUDSTACK-10140: Fix for when template is created from snapshot are corrupted
Date Thu, 01 Jan 1970 00:00:00 GMT
bwsw commented on issue #2322: CLOUDSTACK-10140: Fix for when template is created from snapshot are corrupted
   Hi, @rafaelweingartner 
   Basically, I started from this one:
   it was found by @rhtyd and I fixed Id from 1 to actual code. I don't include it into PR
because master already includes it. Next I went to debugging and opened the issue (CLOUDSTACK-10140)
you saw in Jira.
   root@cs2-secstorage-nfs1:/secondary/template/tmpl/2/209# cat 
   ID is fixed by code from 1st diff, but other information is incorrect including size (I
don't see it in my snippet but AFAIK "size" field was incorrect and included something like
   Next, user provided
the patch and everything started to work fine.
   I suppose that 
   long size = _storage.getSize(destFileFullPath);
   works incorrectly. 
   The actual fix works the next way:
   We write basic info on step one (first try block). Next, we configure format processor
(second try block), like for qcow:
   processor = new QCOW2Processor();
   which actually does the rest of things correctly.  
   I think if basic format is incorrect the processor code stumbles upon it and unable to
write the rest of the format. 
   Frankly speaking, I didn't dive into details and it's a shame but It takes a lot of time
to move across all the ACS code, because I'm not a "real" java developer. But this patch really
works. I patched the 4.10, compiled, deployed into Agent, recreated SSVM and templates started
to work properly. Basically, I recommend to consult Wei Zhou about his patch.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message