cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.
Date Thu, 01 Jan 1970 00:00:00 GMT
mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344772522
 
 
   I?m looking at the logic in StorageSystemSnapshotStrategy.java and it actually flows like
this:
   
   if (volumeInfo.getFormat() == ImageFormat.VHD) {
       HostVO hostVO = getHost(volumeInfo.getId());
   
       computeClusterSupportsVolumeClone = clusterDao.getSupportsResigning(hostVO.getClusterId());
   }
   else if (volumeInfo.getFormat() == ImageFormat.OVA || volumeInfo.getFormat() == ImageFormat.QCOW2)
{
       computeClusterSupportsVolumeClone = true;
   }
   else {
       throw new CloudRuntimeException("Unsupported format");
   }
   
   
   From: Rafael Weing?rtner <notifications@github.com>
   Reply-To: apache/cloudstack <reply@reply.github.com>
   Date: Wednesday, November 15, 2017 at 2:59 PM
   To: apache/cloudstack <cloudstack@noreply.github.com>
   Cc: "Tutkowski, Mike" <Mike.Tutkowski@netapp.com>, Mention <mention@noreply.github.com>
   Subject: Re: [apache/cloudstack] A comprehensive solution for #CLOUDSTACK-9025. (#2315)
   
   
   @mike-tutkowski<https://github.com/mike-tutkowski> I am now taking into consideration
if the storage pool is managed or not.
   I first load the storage pool where the volume of the snapshot is storage, and then I look
for a host that I can use to execute the operation. If the storage pool is of managed type,
I am going to check the parameter you mentioned (?supportsResign?) in the cluster_details
table; I am also expecting that property to be set as true if the host supports resign UUIDs.
   
   Thanks for your help here ;)
   
   P.S. As you mentioned, this changes only affect snapshots in XenServer environments.
   
   ?
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub<https://github.com/apache/cloudstack/pull/2315#issuecomment-344742229>,
or mute the thread<https://github.com/notifications/unsubscribe-auth/AC4SH--VYe8fMnJqzAX4A9cPLYM2XCsCks5s216ugaJpZM4QYrv8>.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message