cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rafaelweingartner commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.
Date Thu, 01 Jan 1970 00:00:00 GMT
rafaelweingartner commented on a change in pull request #2315: A comprehensive solution for
#CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151234003
 
 

 ##########
 File path: engine/schema/src/com/cloud/host/dao/HostDao.java
 ##########
 @@ -103,4 +95,13 @@
     List<HostVO> listByType(Type type);
 
     HostVO findByIp(String ip);
+
+    /**
+     * This method will look for a host that is connected to the storage pool where the volume
of the Snapshot is stored.
+     * <ul>
+     * <li>If the storage pool found for the volume of the snapshotId has more than
a host, we will choose one randomly;
+     * <li>If no host is found, we throw a runtime exception
+     * </ul>
+     */
+    HostVO findHostToOperateOnSnapshot(long snapshotId);
 
 Review comment:
   @mike-tutkowski, following @anshul1886 I changed this code to look for any host in the
zone that is of the same hypervisor type of the cluster where the original volume of the snapshot
resides on. 
   
   So, what do you guys think? let?s use only hosts of the cluster where the volume of the
snapshot has been taken resides on? For me, it seems an easy way to cope with these different
scenarios that we have. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message