cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on a change in pull request #2048: CLOUDSTACK-9880: Expansion of Management IP Range.
Date Thu, 01 Jan 1970 00:00:00 GMT
rhtyd commented on a change in pull request #2048: CLOUDSTACK-9880: Expansion of Management
IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#discussion_r148809158
 
 

 ##########
 File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
 ##########
 @@ -997,7 +999,9 @@ private void checkPodAttributes(final long podId, final String podName,
final lo
         checkIpRange(startIp, endIp, cidrAddress, cidrSize);
 
         // Check if the IP range overlaps with the public ip
-        checkOverlapPublicIpRange(zoneId, startIp, endIp);
+        if(startIp != null) {
 
 Review comment:
   Consider changing this to `Strings.isNullOrEmpty()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message