cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] nitin-maharana commented on a change in pull request #2306: CLOUDSTACK-10129: Allow navigation from VRs to network, instances, owners etc.
Date Thu, 01 Jan 1970 00:00:00 GMT
nitin-maharana commented on a change in pull request #2306: CLOUDSTACK-10129: Allow navigation
from VRs to network, instances, owners etc.
URL: https://github.com/apache/cloudstack/pull/2306#discussion_r148763946
 
 

 ##########
 File path: ui/scripts/system.js
 ##########
 @@ -31,6 +31,7 @@
 
         if (router.projectid) routerType = _l('label.project');
         if (router.vpcid) routerType = _l('label.vpc');
+        if ("isredundantrouter" in router && router.isredundantrouter) routerType
= routerType + " (" + router.redundantstate + ")";
 
 Review comment:
   @rhtyd, Thanks for adding this.
   Can we replace these three if statements with if..else? Or do we override the value in
this order?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message