cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on a change in pull request #2290: WIP: add track id to async api calls
Date Thu, 01 Jan 1970 00:00:00 GMT
rhtyd commented on a change in pull request #2290: WIP: add track id to async api calls
URL: https://github.com/apache/cloudstack/pull/2290#discussion_r148743391
 
 

 ##########
 File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
 ##########
 @@ -333,6 +333,7 @@ public boolean getStartVm() {
                     } catch (NumberFormatException e) {
                         throw new InvalidParameterValueException("Unable to translate and
find entity with networkId: " + ips.get("networkid"));
                     }
+                    // so no network found but a valid number as network id; are we assuming
exceptions thrown or lucky guessing?
 
 Review comment:
   Let's remove comments, unless they're around newly added code or explain existing code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message