Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: GitBox <git@apache.org>
To: commits@cloudstack.apache.org
Subject: [GitHub] rafaelweingartner commented on a change in pull request #2302: CLOUDSTACK-10122: Unrelated error message
Message-ID: <150943677029.6508.16462208437922734492.gitbox@gitbox.apache.org>
archived-at: Tue, 31 Oct 2017 07:59:32 -0000

rafaelweingartner commented on a change in pull request #2302: CLOUDSTACK-10122: Unrelated error message
URL: https://github.com/apache/cloudstack/pull/2302#discussion_r147916282
 
 
 ##########
 File path: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 ##########
 @@ -1423,7 +1423,7 @@ public void prepare(VirtualMachineProfile vm, DeployDestination dest) throws Sto
                     }
                 }
                 catch (Throwable e){
-                    s_logger.debug("[NSX_PLUGIN_LOG] ERROR: " + e.getMessage());
 
 Review comment:
   I would remove the try/catch block. I really did not seen any relevant exception in that piece of code to be dealt if there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services