Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C666C200D4A for ; Tue, 24 Oct 2017 01:38:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C54BA1609E0; Mon, 23 Oct 2017 23:38:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1E656160BF0 for ; Tue, 24 Oct 2017 01:38:58 +0200 (CEST) Received: (qmail 56732 invoked by uid 500); 23 Oct 2017 23:38:57 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 56432 invoked by uid 99); 23 Oct 2017 23:38:57 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Oct 2017 23:38:57 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: Network migration support Message-ID: <150880193651.27373.7753465539776413392.gitbox@gitbox.apache.org> archived-at: Mon, 23 Oct 2017 23:38:59 -0000 GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: Network migration support URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146415351 ########## File path: api/src/com/cloud/network/NetworkService.java ########## @@ -82,6 +83,28 @@ IpAddress allocatePortableIP(Account ipOwner, int regionId, Long zoneId, Long ne Network updateGuestNetwork(long networkId, String name, String displayText, Account callerAccount, User callerUser, String domainSuffix, Long networkOfferingId, Boolean changeCidr, String guestVmCidr, Boolean displayNetwork, String newUUID, boolean updateInSequence, boolean forced); + /** + * Migrate a network from one physical network to another physical network + * @param networkId + * @param networkOfferingId + * @param callerAccount + * @param callerUser + * @param resume + * @return Review comment: Thanks for adding Javadoc. I like the `@param` when it has a description of the parameter otherwise it is better to remove them from the code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services