cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on a change in pull request #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings.
Date Thu, 01 Jan 1970 00:00:00 GMT
rhtyd commented on a change in pull request #2250: CLOUDSTACK-10057: listNetworkOfferings now
returns the correct number  of offerings.
URL: https://github.com/apache/cloudstack/pull/2250#discussion_r147909203
 
 

 ##########
 File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
 ##########
 @@ -4788,7 +4788,7 @@ protected void validateNtwkOffDetails(final Map<Detail, String>
details, final M
             // Now apply pagination
             final List<? extends NetworkOffering> wPagination = StringUtils.applyPagination(supportedOfferings,
cmd.getStartIndex(), cmd.getPageSizeVal());
             if (wPagination != null) {
-                final Pair<List<? extends NetworkOffering>, Integer> listWPagination
= new Pair<List<? extends NetworkOffering>, Integer>(wPagination, offerings.size());
+                final Pair<List<? extends NetworkOffering>, Integer> listWPagination
= new Pair<List<? extends NetworkOffering>, Integer>(wPagination, supportedOfferings.size());
 
 Review comment:
   @sgoeminn why not use `wPagination.size()`, or is it that you want to expose the count
value equal to total found/supported offerings however only return the offerings in the current
page?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message