cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] marcaurele commented on a change in pull request #2302: CLOUDSTACK-10122: Unrelated error message
Date Thu, 01 Jan 1970 00:00:00 GMT
marcaurele commented on a change in pull request #2302: CLOUDSTACK-10122: Unrelated error message
URL: https://github.com/apache/cloudstack/pull/2302#discussion_r147696374
 
 

 ##########
 File path: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 ##########
 @@ -1423,7 +1423,7 @@ public void prepare(VirtualMachineProfile vm, DeployDestination dest)
throws Sto
                     }
                 }
                 catch (Throwable e){
-                    s_logger.debug("[NSX_PLUGIN_LOG] ERROR: " + e.getMessage());
 
 Review comment:
   The log level should be moved to `warn`or `error` so that the message get caught in the
logs when not running in debug. Putting error message as debug should only be done if they
are irrelevant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message