cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sateesh-chodapuneedi commented on a change in pull request #2048: CLOUDSTACK-9880: Expansion of Management IP Range.
Date Thu, 01 Jan 1970 00:00:00 GMT
sateesh-chodapuneedi commented on a change in pull request #2048: CLOUDSTACK-9880: Expansion
of Management IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#discussion_r147092925
 
 

 ##########
 File path: engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDao.java
 ##########
 @@ -45,8 +45,11 @@
 
     int countIPs(long dcId, boolean onlyCountAllocated);
 
+    int countIPs(String ipAddress, long podId, long dcId, boolean onlyCountAllocated);
 
 Review comment:
   @nitin-maharana I'd second the idea to rename the method to `countIpAddressUsage()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message