cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] nitin-maharana commented on a change in pull request #2048: CLOUDSTACK-9880: Expansion of Management IP Range.
Date Thu, 01 Jan 1970 00:00:00 GMT
nitin-maharana commented on a change in pull request #2048: CLOUDSTACK-9880: Expansion of Management
IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#discussion_r146945978
 
 

 ##########
 File path: engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDao.java
 ##########
 @@ -45,8 +45,11 @@
 
     int countIPs(long dcId, boolean onlyCountAllocated);
 
+    int countIPs(String ipAddress, long podId, long dcId, boolean onlyCountAllocated);
 
 Review comment:
   The delete operation requires searching for an entry in the op_dc_ip_address_alloc table
based on a particular IP address. It checks if that IP is allocated to anyone before deleting.

   It cannot be implemented in one method because the other usages search for a range in a
DC or in a POD. Hope this clarifies!!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message