cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: Network migration support
Date Thu, 01 Jan 1970 00:00:00 GMT
GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: Network migration
support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146418796
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##########
 @@ -1196,6 +1222,10 @@ private void getPifs() {
         s_logger.debug("done looking for pifs, no more bridges");
     }
 
+    boolean isGuestBridge(String bridge) {
 
 Review comment:
   Thanks! Removing the duplicate code is great ?
   If you want, you can go a step further creating a test case for `isGuestBridge(String bridge)`
and `isPublicBridge(String bridge)` ;)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message