cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: Network migration support
Date Thu, 01 Jan 1970 00:00:00 GMT
GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: Network migration
support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146415351
 
 

 ##########
 File path: api/src/com/cloud/network/NetworkService.java
 ##########
 @@ -82,6 +83,28 @@ IpAddress allocatePortableIP(Account ipOwner, int regionId, Long zoneId,
Long ne
     Network updateGuestNetwork(long networkId, String name, String displayText, Account callerAccount,
User callerUser, String domainSuffix, Long networkOfferingId,
         Boolean changeCidr, String guestVmCidr, Boolean displayNetwork, String newUUID, boolean
updateInSequence, boolean forced);
 
+    /**
+     * Migrate a network from one physical network to another physical network
+     * @param networkId
+     * @param networkOfferingId
+     * @param callerAccount
+     * @param callerUser
+     * @param resume
+     * @return
 
 Review comment:
   Thanks for adding Javadoc.
   I like the `@param` when it has a description of the parameter otherwise it is better to
remove them from the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message