cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: Network migration support
Date Thu, 01 Jan 1970 00:00:00 GMT
GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024: Network migration
support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146415652
 
 

 ##########
 File path: engine/schema/src/com/cloud/tags/dao/ResourceTagDao.java
 ##########
 @@ -34,5 +34,22 @@
 
     List<? extends ResourceTag> listBy(long resourceId, ResourceObjectType resourceType);
 
+    /**
+     * Find a resource tag based on the resourceid, resourcetype and key
+     * @param resourceId
+     * @param resourceType
+     * @param key
+     * @return
+     */
+    ResourceTag findByKey(long resourceId, ResourceObjectType resourceType, String key);
+
     void updateResourceId(long srcId, long destId, ResourceObjectType resourceType);
+
+    /**
+     * remove a resource tag based on the resourceid, resourtype and key
+     * @param resourceId
+     * @param resourceType
+     * @param key
 
 Review comment:
   Same here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message