cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] nitin-maharana commented on a change in pull request #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM
Date Thu, 01 Jan 1970 00:00:00 GMT
nitin-maharana commented on a change in pull request #2295: CLOUDSTACK-10109: Enable dedication
of public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#discussion_r146011896
 
 

 ##########
 File path: ui/scripts/system.js
 ##########
 @@ -85,22 +91,42 @@
                         success: function (json) {
                             var domain = json.listdomainsresponse.domain[0];
 
+                            if (data.forSystemVms != null) {
+                                systemvms = '<li>' + _l('label.system.vms') + ': '
+ data.forSystemVms + '</li>'
+                            }
                             if (data.account != null)
                                 cloudStack.dialog.notice({
-                                    message: '<ul><li>' + _l('label.account')
+ ': ' + data.account + '</li>' + '<li>' + _l('label.domain') + ': ' + domain.path
+ '</li></ul>'
+                                    message: '<ul><li>' + _l('label.account')
+ ': ' + data.account + '</li>' + '<li>' + _l('label.domain') + ': ' + domain.path
+ '</li>' + systemvms + '</ul>'
                                 });
                             else
                                 cloudStack.dialog.notice({
-                                    message: '<ul><li>' + _l('label.domain')
+ ': ' + domain.path + '</li></ul>'
+                                    message: '<ul><li>' + _l('label.domain')
+ ': ' + domain.path + '</li>' + systemvms + '</ul>'
                                 });
                         }
                     });
                 } else {
                     cloudStack.dialog.createForm({
                         form: {
-                            title: 'label.add.account',
-                            desc: '(optional) Please specify an account to be associated
with this IP range.',
-                            fields: fields
+                            title: 'label.set.reservation',
+                            desc: '(optional) Please specify an account to be associated
with this IP range.<br/><br/>'+
 
 Review comment:
   Can you please replace the sentence with a dictionary key here. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message