cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From raj...@apache.org
Subject [2/2] git commit: updated refs/heads/master to 09802e0
Date Mon, 13 Mar 2017 16:44:14 GMT
Merge pull request #1861 from sateesh-chodapuneedi/pr-cloudstack-9698

CLOUDSTACK-9698 [VMware] Make hardcorded wait timeout for NIC adapter hotplug as configurableJira
===
CLOUDSTACK-9698 [VMware] Make hardcoded wait timeout for NIC adapter hotplug as configurable

Description
=========
Currently ACS waits for 15 seconds (hard coded) for hot-plugged NIC in VR running on VMware
to get detected by guest OS.
The time taken to detect hot plugged NIC in guest OS depends on type of VMware NIC adapter
like (E1000, VMXNET3, E1000e etc.)
and guest OS itself. In uncommon scenarios the NIC detection may take longer time than 15
seconds,
in such cases NIC hotplug would be treated as failure which results in VPC tier configuration
failure.
Alternatively making the wait timeout for NIC adapter hotplug as configurable will be helpful
for admins in such scenarios. This is specific to VR running over VMware hypervisor.

Also in future if VMware introduces new NIC adapter types which may take time to get detected
by guest OS, it is good to have flexibility of
configuring the wait timeout as fallback mechanism in such scenarios.

Fix
===
Introduce new configuration parameter (via ConfigKey) "vmware.nic.hotplug.wait.timeout" which
is "Wait timeout (milli seconds) for hot plugged NIC of VM to be detected by guest OS." as
fallback instead of hard coded timeout, to ensure flexibility for admins given the listed
scenarios above.

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapuneedi@accelerite.com>

* pr/1861:
  CLOUDSTACK-9698 Make the wait timeout for NIC adapter hotplug as configurable

Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/09802e0f
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/09802e0f
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/09802e0f

Branch: refs/heads/master
Commit: 09802e0f3c7a488545248e03431b9741076b1942
Parents: 56e851c d171bb7
Author: Rajani Karuturi <rajani.karuturi@accelerite.com>
Authored: Mon Mar 13 22:12:54 2017 +0530
Committer: Rajani Karuturi <rajani.karuturi@accelerite.com>
Committed: Mon Mar 13 22:12:54 2017 +0530

----------------------------------------------------------------------
 .../hypervisor/vmware/manager/VmwareManager.java   |  5 +++++
 .../vmware/manager/VmwareManagerImpl.java          | 17 ++++++++++++++---
 .../hypervisor/vmware/resource/VmwareResource.java |  3 ++-
 3 files changed, 21 insertions(+), 4 deletions(-)
----------------------------------------------------------------------



Mime
View raw message