cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [33/50] [abbrv] git commit: updated refs/heads/4.9-bountycastle-daan to 4817cb6
Date Wed, 11 May 2016 09:43:21 GMT
Merge pull request #1529 from mike-tutkowski/marvin_replace_sleep

Marvin: Replace a timer.sleep(30) with pulling logic

>From the ticket:

In the file, there is a Host class with a delete instance method.

This method first attempts to transition the host into the maintenance resource state.

The first step in this process is to transition the host into the prepare-for-maintenance
resource state.

A while later, the host can be transitioned completely into the maintenance resource state.

In an attempt to wait for this transition to occur, the delete method has a timer.sleep(30)

The hope is that the host will have transitioned from the prepare-for-maintenance resource
state to the maintenance resource state within 30 seconds, but this does not always happen.

We should correct this problem by putting in logic to query the management server for the
resource state of the host. If it's in the expected state, move on; else, sleep for a bit
and try again (up to a certain limit).

* pr/1529:
  Replace a timer.sleep(30) with pulling logic

Signed-off-by: Will Stevens <>


Branch: refs/heads/4.9-bountycastle-daan
Commit: 10bcf2955a436104bba96517dff9ce41ae2af7b7
Parents: ccf2265 eeb3373
Author: Will Stevens <>
Authored: Wed May 11 00:03:58 2016 -0400
Committer: Will Stevens <>
Committed: Wed May 11 00:03:59 2016 -0400

 tools/marvin/marvin/    | 25 +++++++++++++++++++++++++
 tools/marvin/marvin/lib/ | 36 ++++++++++++++++++++++++++++++++----
 2 files changed, 57 insertions(+), 4 deletions(-)

View raw message